search

microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.31k stars 577 forks source link

user icons are not loaded for Github Enterprise in PR Detail page #4020

Open aelam opened 2 years ago

aelam commented 2 years ago

Steps to Reproduce:

  1. open the PR list in VSCode
  2. choose one PR, it will open the PR detail (NOT the commits history of PR)
  3. You can see your own icons and comment icons in the PR detail
ericohlin commented 2 years ago

We don't get the icons we have set in github, but we do get little robot icons. image

aelam commented 2 years ago

@ericohlin Sorry for confusing you,

You check one PR detail in VSCode You can see your own icon and comments with icons I've updated the issue to be more detailed

alexr00 commented 1 year ago

This should be starting with version 0.52.0 of the extension. If it's not, please ping the issue again and I will investigate!

aelam commented 3 months ago

@alexr00 Sorry for late. The fixed version shows github icon for enterprise in my case I debugged this issue, it's an authentication issue, the iconUrl was correct, the avatarUrl is like this https://<git enterprise URL>/avatars/[number]/... I think the token is needed to request the icon

I tested attaching the token to the request, it doesn't work.

I'm not sure if there is any other way to do it.

sorry for bothering

aelam commented 2 months ago

reopen