search

microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.3k stars 575 forks source link

Disable issue name expansion #4284

Open unional opened 1 year ago

unional commented 1 year ago

Right now when typing # it will show existing issues on GitHub which is great. But selecting it will insert the issue name along with the issue number.

This will make GitHub not able to detect the PR will closes the referenced issue.

e.g.:

Fixes #  // <-- here the extension will list existing issues.

// After selecting the issue, it becomes
Fixes Is MissingAction really a problem? #421

I would suggest to just fill in the issue number, like this:

Fixes #421

Then when the PR is merged, GitHub will close the referenced issue automatically.

alexr00 commented 1 year ago

Looks like we need a similar setting to githubIssues.issueCompletionFormatScm, but for the editor.

tobbi commented 11 months ago

Is there a way to detect whether the issue number was preceded by "Fixes|Closes"?

matthewberryman commented 1 month ago

I'd prefer fixes #421 Is MissingAction really a problem? to use the example, so the description is given, but after the issue number so that the fixes #nnn magic still works.