Open mfulton26 opened 1 year ago
alexr00
commented
1 year ago The command "Go to Next Diff in Pull Request" will go to the next diff across files. The command "Mark File as Viewed" will mark the active file as viewed. You can set keyboard shortcuts for both of these commands.
alexr00
commented
1 year ago What's missing is a way to run one command to mark as viewed and go to the next file.
mfulton26
commented
1 year ago hmmmm… I don't see commands named "Go to Next Diff in Pull Request" or "Mark File as Viewed" 🤔
mfulton26
commented
1 year ago It doesn't appear to show up when viewing image diffs. At first it didn't show up for me when view .ts file diffs either but after viewing the shortcut in the keyboard shortcuts settings in VS Code now it shows up. Maybe there is some bug around the command not being available for non-text files (e.g. images).
mfulton26
commented
1 year ago I would like a "Go to Previous Diff in Pull Request" too (I don't see that one currently).
alexr00
commented
1 year ago "Go to Previous Diff in Pull Request" is already available in the pre-release build. We do indeed only show the commands when the file is a text diff. I can look at expanding this to other diffs in February.
mfulton26
commented
1 year ago Awesome. Thank you.
On Wed, Jan 25, 2023, 3:44 AM Alex Ross @.***> wrote:
"Go to Previous Diff in Pull Request" is already available in the pre-release build. We do indeed only who the commands when the file is a text diff. I can look at expanding this to other diffs in February.
— Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-pull-request-github/issues/4424#issuecomment-1403339901, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKUPXK34BOXNXHBIEKLTVLWUDYXPANCNFSM6AAAAAAUBZS3RU . You are receiving this because you authored the thread.Message ID: @.***>
diminutivesloop
commented
11 months ago The existing commands are helpful but it would be great if there was a button in the toolbar for moving quickly to the next or previous diff/file in a PR without marking it as read. Sometimes I like to start a PR review by quickly looking through the files before reviewing them in depth and so I don't always want to mark them as read before moving on.
TristenFielding
commented
3 months ago Actually, the button that marks the file as view should not only close the current file but then open the next file.
I would like to be able to quickly iterate through changed files. e.g. One project I work on regularly has visual snapshots checked into the repository. When things change visually it is usually just a handful of snapshots but sometimes lots of images get updated. (e.g. We change global padding on our text inputs across many views.)
I would like to be able to press a button or a keyboard shortcut to go to the next file, etc.
Personally I would also like to be able to mark a file as viewed through a keyboard shortcut or even be able to mark the current file as viewed and automatically jump to the next file not marked as viewed.