microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.32k stars 579 forks source link

Extension causes re-opening of closed read-only buffer #6109

Open sezna opened 4 months ago

sezna commented 4 months ago

I believe this might be a duplicate of #6087 but it also might not be.

Steps to Reproduce:

We publish an extension called Azure Quantum Development Kit. To reproduce this issue, use our latest development pre-release build and go-to def on a file.

  1. Install VS Code extension quantum.qsharp-lang-vscode-dev
  2. Open a .qs file
  3. Type "shor" and select "Shor sample" from the autocomplete
  4. go-to definition on any standard library function. For example, ApplyXorInPlace
  5. Close the read-only buffer that was just opened to render the standard library. Note that an additional event is triggered that re-opens the file and brings the diagnostics back.

This error disappears when we uninstall the pull requests extension.

Thanks for your help!

alexr00 commented 3 months ago

It does sound similar to https://github.com/microsoft/vscode-pull-request-github/issues/6087

alexr00 commented 3 months ago

Just like https://github.com/microsoft/vscode-pull-request-github/issues/6087, I can't repro this. Can you set the log level of GitHub Pull Request to trace, repro, then share the output of GitHub Pull Request? I'm not sure that there will be anything in there that shows what's going on, but it's easy to collect.