search

microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.32k stars 583 forks source link

Don't show "make suggestion" when there's already a suggestion in the editor #6202

Closed alexr00 closed 2 months ago

alexr00 commented 2 months ago

Fixes #6195

mfulton26 commented 1 month ago

GitHub web UI allows making multiple suggestions in a single comment. With this change will that still be possible? Maybe "Make a Suggestion" should only be disabled when the cursor is inside the suggestion code block/fence.

alexr00 commented 1 month ago

With this change, the button is disabled, so you can't easily add another suggestion. Do you find yourself often adding multiple suggestions to one comment? What's your use case for this?

mfulton26 commented 1 month ago

I don't think it is often, maybe every 1 in 30 comments. The main use case is when something needs cleaning-up but there are multiple ways to do it, so I'll leave two (sometimes even three) different suggestions to choose from. I think not limiting functionality in VSCode compared to GitHub UI is important in and of itself but as it isn't a critical thing (plus I can write ```suggestion out myself manually if needed) then I don't think it is critical to fix but it would be nice IMO (to have parity with GitHub UI, etc.).