Pull Request Template is not populated when new Pull Request is created from github.dev

[dmilburn]

• Extension version:
• VSCode Version:
• OS: MacOS Sanoma v14.5
• Repository Clone Configuration (single repository/fork of an upstream repository):
• Github Product (Github.com/Github Enterprise version x.x.x): github.com

Hi, this issue was escalated from GitHub's support team. We believe you're the owners of the github.dev so we're transferring it here:

Customer is reporting that their Pull Request Template - which is stored in the default branch - is not loaded in new Pull Requests created from within github.dev.

Pull Requests created from the regular Repository UI work just fine.

The customer has shared a screen recording demonstrating the issue. (It contains the name of a user's private repository so I didn't include it in this issue. It can be seen in the original issue or please reach out to me through internal channels if you can't see that issue.)

OS: MacOS Sanoma v14.5 Web Browser: Chrome Version 126.0.6478.62 (Official Build) (arm64)

Customer Impact

Include information about customer impact, including which key/strategic customers are impacted. Include org/repo/user information for this issue where possible. Link to Zendesk Ticket(s) : 2892807

[alexr00]

Based on the video this doesn't look like it's using the GitHub Pull Request extension. @joyceerhl, it looks like it's using the Remote Repositories extension's PR flow. I imagine that this just isn't something that Remote Repositories supports. Which repos do Remote Repositories issues go in?

[joyceerhl]

@alexr00 would it make sense for GHPRI to offer this action so we can remove it from RemoteHub?

[alexr00]

GHPR does offer a way to create a PR from the SCM view. I think we left in in RemoteHub too for the cases where GHPR isn't installed.

[joyceerhl]

But GHPRI is installed in github.dev by default 🤔 so in this scenario there shouldn't be a RemoteHub create PR flow

[alexr00]

It looks like the user in the screen recording might have disabled "GitHub Pull Requests" @dmilburn would you be able to confirm this?

@joyceerhl, it looks like RemoteHub already tries to do the right thing: https://github.com/microsoft/vscode-remotehub/blob/fd911c88373583c8995082d7d5cd3293de822da8/extensions/remotehub/package.json#L815-L819

Do we want to keep this, or if the embedder is vscode.dev or github.dev should we prevent the action from getting added?

[dmilburn]

It looks like the user in the screen recording might have disabled "GitHub Pull Requests" @dmilburn would you be able to confirm this?

@danielhardej could you reach out to them please?

[danielhardej]

Sure thing @dmilburn - just asked them and will let you know.

[danielhardej]

Hi again @dmilburn @alexr00 . Customer says yes, it's enabled.

[alexr00]

@danielhardej it doesn't look like it's enabled. Can you have them share a screen shot of the Extensions view with GitHub Pull Request in the view? Ex:

[danielhardej]

Hey @alexr00 This is what they shared with me:

[alexr00]

Thanks! Have they signed in to GitHub Pull Requests? They can check by going to the Accounts menu:

[danielhardej]

Checking that for you now...

[danielhardej]

okay, this is strange. The extension is installed and enabled for them, but doesn't appear under their Trusted Extensions list

[alexr00]

It looks like they haven't signed in yet. They should just be able to open the Pull Requests view and use the sign in button. If they can't find the view, then the command "GitHub Pull Requests: Sign in with GitHub" should get them signed in.