search

microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.32k stars 583 forks source link

Contribute to SCM Graph item context menu (proposed API in 1.94) #6239

Closed gjsjohnmurray closed 1 month ago

gjsjohnmurray commented 1 month ago

This PR implements #6236

gjsjohnmurray commented 1 month ago

image

gjsjohnmurray commented 1 month ago

Looks like something needs to be done at the VS Code end to "bless" this extension's use of another proposed API.

image

alexr00 commented 1 month ago

@lszomoru is it ok if GHPR uses contribSourceControlHistoryItemMenu?

lszomoru commented 1 month ago

These actions should be contributed through the built-in github extension. Filed https://github.com/microsoft/vscode/issues/229349 to track this.

gjsjohnmurray commented 1 month ago

@lszomoru good point. I had overlooked that there's a built-in GH one too. If I reimplement this PR over there will you consider taking it?

lszomoru commented 1 month ago

Sure, please go ahead. This is something for next milestone though...

gjsjohnmurray commented 1 month ago

Replaced by https://github.com/microsoft/vscode/pull/229386