search

microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.3k stars 574 forks source link

Search string in modified pull request files #6240

Open Splines opened 1 week ago

Splines commented 1 week ago

Thanks for this amazing extension, works like a charm 🎉

A feature I'd be looking forward to is to limit the VSCode in-built search to files that were modified in the currently checked out pull request. Additionally, an option to only search in the modified lines of these files would also be great.

This feature could help get a better understanding of what a PR changed as you would be able to easily search in it for strings you've seen somewhere in the modified lines and find out about its usage and how files are related to each other. Without this limited search, many more occurrences of a given string in the entire codebase might show up making it harder to discern what was changed in the PR and what not.

alexr00 commented 5 days ago

Cool idea! @andreamah is this something that the search API you've been working on might enable?

andreamah commented 5 days ago

Hmm. Since the files will still be of file scheme, the fileSearchProvider and textSearchProvider won't apply to this case. It's mostly if you have a custom filesystem / scheme.