microsoft / vscode-pull-request-github

GitHub Pull Requests for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
MIT License
2.32k stars 579 forks source link

Suggestions end up in unsubmittable pending state #6494

Open MetRonnie opened 6 days ago

MetRonnie commented 6 days ago

Steps to Reproduce:

  1. Make multiple changes to different "hunks" in a file and click the "Create pull request suggestions" button in the Source Control panel

    Here my suggestions ended up as 4 pending comments:

    https://github.com/user-attachments/assets/d2b85688-b315-4241-9fb8-c5dc623a57a7

  2. This can lead to multiple individual reviews being started on GitHub and only being able to submit a subset of the suggestions in the review

    On the GH website only 1 comment is in the review:

    https://github.com/user-attachments/assets/1e368a61-3c32-4a7b-9595-6f6aa52685c8

    The other comments end up stuck as pending and cannot be submitted in a review

This is superficially similar to #4291, but in this case the comments clearly are making their way to the server in the pending state, but cannot be submitted.

https://github.com/microsoft/vscode-pull-request-github/issues/1317 may also be relevant