microsoft / vscode-python-web-wasm

An extension allows to run Python code in a Web browser using WebAssembly technology
MIT License
78 stars 11 forks source link

Port pdb debugger to this repository #16

Closed rchiodo closed 1 year ago

rchiodo commented 2 years ago

Moved the code I had in https://github.com/microsoft/vscode-wasm/pull/27 to this repository instead.

@dbaeumer I didn't wire up the web version of the debugger, and the desktop version is not using a WASI, but figured that would happen later once you get the new file descriptor setup.

dbaeumer commented 2 years ago

I think? you can pass args to a worker? If not a message could be created to pass the args to pdb inside the worker.

Yes, in node but not in the browser. In the browser you need to decode them as a param string. See https://github.com/microsoft/vscode-wasm/blob/74b49f8c2df9ecb807a934ba0de86f6fb1db5b92/sync-api-common/src/browser/ril.ts#L74 and https://github.com/microsoft/vscode-wasm/blob/74b49f8c2df9ecb807a934ba0de86f6fb1db5b92/sync-api-common/src/node/ril.ts#L74

dbaeumer commented 2 years ago

The code looks fine to me. I would only like to ask for one thing: if methods are private we should prefix them with the private keyword in TS and not only rely on the underscore. We don't have a clear rule in VS Code but most of the devs (including me) don't prefix private members with _ but only rely on the visiblity modifiers provided by TS.

I propose that I add you as a committer to the repository so that you can merge the PR when approved.

rchiodo commented 2 years ago

The code looks fine to me. I would only like to ask for one thing: if methods are private we should prefix them with the private keyword in TS and not only rely on the underscore. We don't have a clear rule in VS Code but most of the devs (including me) don't prefix private members with _ but only rely on the visiblity modifiers provided by TS.

I propose that I add you as a committer to the repository so that you can merge the PR when approved.

Sure sounds good.

dbaeumer commented 1 year ago

Code got merge from another PR. Closing