search

microsoft / vscode-python

Python extension for Visual Studio Code
https://aka.ms/pvsc-marketplace
MIT License
4.32k stars 1.19k forks source link

Revert VSCode FS changes to generally address reparse point #11348

Open karthiknadig opened 4 years ago

karthiknadig commented 4 years ago

VSC FS fails to get stat or list reparse points. This affects cases where we need to find them, such as Store Windows Python. Currently we have a band-aid fix for this https://github.com/microsoft/vscode-python/pull/11340 . One thing we can do is address this correctly by reverting to old behavior.

Note that simply substituting readDirectory with listdir is not sufficient. We will need to provide proper FileType translation. We need to ensure that this translation matches the file types that VSC FS provides if the two APIs need to co-exist.

We have two options:

  1. Find each impacted API and address it individually
  2. Revert all VSC FS changes
karthiknadig commented 4 years ago

Reverting could also address, stability issues with createWriteStream. See #11940

luabud commented 4 years ago

Let's switch back to fs-extra