microsoft / vscode-python

Python extension for Visual Studio Code
https://aka.ms/pvsc-marketplace
MIT License
4.33k stars 1.19k forks source link

Controlled rollout of notifying about the `black`/`pylint`/`isort` extension. #19653

Closed karthiknadig closed 1 year ago

karthiknadig commented 2 years ago
karthiknadig commented 2 years ago

@luabud How does this look like for the transition to extension?

flowchart TD
    start([start])
    finished([end])

    is_linter_enabled{Is Linter Enabled?}
    has_args{Has Linter args?}
    are_simple_args{Are simple args?}
    install_extensions{Install extensions?}

    show_prompt[Show prompt]
    no_prompt[No prompt]

    trigger_install[trigger install]
    copy_args[Copy arguments]

    start --> is_linter_enabled

    is_linter_enabled -- yes --> has_args
    is_linter_enabled -- no --> no_prompt

    has_args -- yes --> are_simple_args
    has_args -- no --> show_prompt 

    are_simple_args -- yes --> show_prompt
    are_simple_args -- no --> no_prompt

    show_prompt --> install_extensions 

    install_extensions -- no --> finished
    install_extensions -- yes --> trigger_install

    trigger_install --> copy_args

    copy_args --> finished
    no_prompt --> finished
luabud commented 2 years ago

This looks good to me! If users don't have args, wouldn't we want to transition them to the new extensions as well?

karthiknadig commented 1 year ago

@luabud Can you verify this when you get the chance for Formatting prompt?