Notebook support for linting and formatting

microsoft / vscode-python

Python extension for Visual Studio Code

https://aka.ms/pvsc-marketplace

MIT License

4.32k stars 1.18k forks source link

Notebook support for linting and formatting #21142

Open karthiknadig opened 1 year ago

karthiknadig commented 1 year ago

[x] Implement Notebook support in pygls
[ ] Implement Linting for notebooks in pylint.
[ ] Implement Linting for notebooks in flake8.
[ ] Implement Linting for notebooks in mypy.
[ ] Implement Formatting for notebooks in black
[ ] Implement Formatting for notebooks in autopep8

rebornix commented 1 year ago

@karthiknadig currently we have "Format Notebook" command in the core and also notebook format on save. If users have black extensions installed, it works as expected. May I ask if this would change how we run formatters from the core?

karthiknadig commented 1 year ago

From what I can tell, it should not. The LSP server registers itself as a server that can handle notebooks. When I have a prototype ready, we can look at how LSP client handles notebook mode registration.