microsoft / vscode-python

Python extension for Visual Studio Code
https://aka.ms/pvsc-marketplace
MIT License
4.34k stars 1.19k forks source link

Integrated terminal profile using tmux creates additional session #23305

Open nicolasbock opened 6 months ago

nicolasbock commented 6 months ago

Type: Bug

Steps to Reproduce:

  1. Create terminal.integrated.profiles.linux:
        "tmux": {
            "path": "tmux",
            "args": ["new-session", "-A", "-s", "vscode_${workspaceFolderBasename}"],
            "icon": "terminal-tmux"
        },
  2. Open project
  3. Open terminal (View: Toggle Terminal)
  4. In the terminal, ask tmux to list-sessions:
    10: 1 windows (created Fri Apr 26 07:32:01 2024) (attached)
    vscode_workfolder: 1 windows (created Tue Apr 23 13:52:52 2024) (attached)
  5. List clients (tmux:list-clients)
    /dev/pts/10: 10 [80x30 xterm-256color] (attached,focused,UTF-8)
    /dev/pts/13: vscode_workfolder [172x28 xterm-256color] (attached,focused,UTF-8)
  6. Find PPID of client
    $ ps -ef | grep 1192836
    nbock    1192836 1192393  0 07:31 ?        00:00:07 /snap/code/157/usr/share/code/code --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=1192409 --enable-crash-reporter=ef1bdb8e-20f4-4c73-9c31-fe68457a5e07,no_channel --user-data-dir=/home/nbock/.config/Code --standard-schemes=vscode-webview,vscode-file --secure-schemes=vscode-webview,vscode-file --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --code-cache-schemes=vscode-webview,vscode-file --shared-files=v8_context_snapshot_data:100 --field-trial-handle=0,i,8387895058486388577,14595205004707220095,262144 --enable-features=kWebSQLAccess --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess --variations-seed-version
    nbock    1193112 1192836  0 07:32 pts/10   00:00:00 /usr/bin/tmux
    nbock    1193315 1192836  0 07:32 pts/13   00:00:00 /usr/bin/tmux new-session -A -s vscode_workfolder
    nbock    1197709   18872  0 07:52 pts/3    00:00:00 grep --color=auto 1192836

Extension version: 2024.4.1 VS Code version: Code 1.88.1 (e170252f762678dec6ca2cc69aba1570769a5d39, 2024-04-10T17:34:12.840Z) OS version: Linux x64 6.8.0-31-generic snap Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz (8 x 3446)| |GPU Status|2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: disabled_off| |Load (avg)|6, 4, 3| |Memory (System)|39.05GB (20.51GB free)| |Process Argv|--no-sandbox --force-user-env --unity-launch --crash-reporter-id c83bfc13-e8ad-4587-abf1-e2107699a982| |Screen Reader|no| |VM|60%| |DESKTOP_SESSION|ubuntu| |XDG_CURRENT_DESKTOP|Unity| |XDG_SESSION_DESKTOP|ubuntu| |XDG_SESSION_TYPE|wayland|
A/B Experiments ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscoreces:30445986 vscod805:30301674 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pyreplss1:30897532 pythonmypyd1:30879173 pythoncet0:30885854 h48ei257:31000450 pythontbext0:30879054 accentitlementsc:30995553 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 d34g3935:30971562 fegfb526:30981948 bg6jg535:30979843 ccp1r3:30993539 dsvsc020:30976470 pythonait:31006305 gee8j676:31009558 showvideoc:31016891 chatpanelc:31018788 dsvsc021:30996838 9c06g630:31013171 pythoncenvpt:31022790 ```
karthiknadig commented 6 months ago

Moving this to VS Code as this has nothing to do with python extension.

nicolasbock commented 6 months ago

Thanks @karthiknadig . Just to clarify: I did the extension bisect and this issue only occurs with this extension being active in a Python project. Why is this issue then not related to the extension?

meganrogge commented 6 months ago

Reassigning to you based on the above comment @karthiknadig

karthiknadig commented 6 months ago

@nicolasbock It wasn't clear from the initial issue that this was specific to python. I can move this back to Python.