microsoft / vscode-python

Python extension for Visual Studio Code
https://aka.ms/pvsc-marketplace
MIT License
4.31k stars 1.18k forks source link

Logging consolidation - Remove `window.console` and `console.` calls #9721

Open kimadeline opened 4 years ago

kimadeline commented 4 years ago

From the #9611 spike for #8527

Remove direct calls to window.console.([log|warn|info|error]), replace them with trace[Verbose|Warn|Info|Error] or @traceDecorators.

⚠️ The DS part of the extension overrides window.console with their own messaging API, so make sure we don't impact them.

karthiknadig commented 4 years ago

Check for console.log as well.

karthiknadig commented 4 years ago

Direct uses of console.

karthiknadig commented 4 years ago

Spoke to the DS team. We should not be replacing console.log inside DataScience-ui/react*

karthiknadig commented 4 years ago

Data science portion of this will be cleaned up via #9832

karthiknadig commented 4 years ago

Not making change to anything under debugAdapter. Since we are going to phase it out.