search

microsoft / vscode-recipes

MIT License
5.86k stars 577 forks source link

Docker-TypeScript unbound breakpoint #266

Closed rotemironsrc closed 2 years ago

rotemironsrc commented 4 years ago

took your project as is, and breakpoint never get hit while debugging.

vscode June 2020 (version 1.47)

hurulis commented 4 years ago

+1 , same here

alanbo commented 4 years ago

+1, same here

weinand commented 4 years ago

Does it make a difference if you disable our new js-debugger by adding a "debug.javascript.usePreview": false to your settings?

rotemironsrc commented 4 years ago

Nope, but i now know that the problem is, when you open the window to show all the folders, and then try to debug.

On Tue, Jul 28, 2020 at 11:22 AM Andre Weinand notifications@github.com wrote:

Does it make a difference if you disable our new js-debugger by adding a "debug.javascript.usePreview": false to your settings?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-recipes/issues/266#issuecomment-664853849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM37UTLL3BJ62TXZP5BRM4DR52DCRANCNFSM4O2HJBQA .

rotemironsrc commented 4 years ago

also it doesn't work with workspace.

On Tue, Jul 28, 2020 at 12:52 PM Rotem Levi rotem.levi@ironsrc.com wrote:

Nope, but i now know that the problem is, when you open the window to show all the folders, and then try to debug.

On Tue, Jul 28, 2020 at 11:22 AM Andre Weinand notifications@github.com wrote:

Does it make a difference if you disable our new js-debugger by adding a "debug.javascript.usePreview": false to your settings?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-recipes/issues/266#issuecomment-664853849, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM37UTLL3BJ62TXZP5BRM4DR52DCRANCNFSM4O2HJBQA .

weinand commented 4 years ago

Yes, make sure to only open the Docker-TypeScript folder in VS Code and not the enclosing recipes folder.

BTW, the Docker-TypeScript recipe is outdated (and obsolete). It was created in a time when VS Code did not have universal remote development capabilities and only its Node.js debugger was able to debug remotely. Today we recommend to use VS Code's excellent container development support. With this, TypeScript development in a Docker container is not different than TypeScript development in a local setup.

rotemironsrc commented 4 years ago

i need a way to debug in workspace, i want to able to debug multiple services inside the docker from one window. is it possible?

On Tue, Jul 28, 2020 at 3:24 PM Andre Weinand notifications@github.com wrote:

Yes, make sure to only open the Docker-TypeScript folder in VS Code and not the enclosing recipes folder.

BTW, the Docker-TypeScript is outdated (and obsolete). It was created in a time when VS Code did not have universal remote development capabilities https://code.visualstudio.com/docs/remote/remote-overview and only its Node.js debugger was able to debug remotely. Today we recommend to use VS Code's excellent container development support https://code.visualstudio.com/docs/remote/containers. With this, TypeScript development in a Docker container is not different than TypeScript development in a local setup.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-recipes/issues/266#issuecomment-665008517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM37UTM6IFOGQA5ZRO6QCVTR527P3ANCNFSM4O2HJBQA .

weinand commented 4 years ago

If you use a multi-folder workspace setup for the different services, you can debug them in different debug sessions within one window.

rotemironsrc commented 4 years ago

how ? can you send me a reference ? i have a docker-compose file for all of my services i have a workspace containing separate folders for each service i have. in each folder i have .devcontainer folder with devcontainer.json and docker-compose and a dockerfile but i see the only way to debug each service i need to open each one in a new window.

rotemironsrc commented 4 years ago

Currently you can only connect to one container per VS Code window according to your documentation it is not possible yet.

suhaasprasad commented 4 years ago

Any update here?

weinand commented 4 years ago

As said already above:

The Docker-TypeScript recipe is outdated (and obsolete). It was created in a time when VS Code did not have universal remote development capabilities and only its Node.js debugger was able to debug remotely. Today we recommend to use VS Code's excellent container development support. With this, TypeScript development in a Docker container is not different than TypeScript development in a local setup.