microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.55k stars 263 forks source link

[Remote-SSH Bug]: Error connecting to any remote: withRevealTerminalEvent can only be called once at a time globally within the app #10015

Open akosyakov opened 1 week ago

akosyakov commented 1 week ago

Is there an existing issue for this bug?

Required Troubleshooting Steps

Connect Locally

It doesn’t connect successfully (same error message)

->

I have several extensions which depend on remote SSH extension and some users are failing to connect because of it. This issue was reported before https://github.com/microsoft/vscode/issues/197512 We could apply similar workaround on our side, but it looks like a bug.

Expected Behavior

The remote SSH extension shoudl not activate twice, regardless of dependencies.

Steps To Reproduce

No response

Remote-SSH Log

Remote-SSH Log

``` [PASTE LOG HERE] ```

Anything else?

No response

roblourens commented 1 week ago

I'm confused about how you end up triggering this error. Can you explain some more what the extensions do?

roblourens commented 1 week ago

I tried adding remote-ssh as an extensionDependency to an extension, and I don't see the issue, what do you mean by 'depend on remote SSH'?

akosyakov commented 6 days ago

@roblourens it seems to trigger only on Windows and if there are several extensions depending on remote-ssh are activated in the remote window. Yes via extensionDependencies. Maybe timing of extension activation is matter too, for ours it was with onResolveRemoteAuthority:ssh-remote activation event.

roblourens commented 6 days ago

I'll try it, but using onResolveRemoteAuthority:ssh-remote may not work, it's sort of a special activation event for resolvers. And these extensions are on the remote side? Remote-SSH is a local extension, maybe that's part of the problem too.