microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.63k stars 282 forks source link

Reopen in Container does not work from Popup, but from command palette #10072

Closed NINI1988 closed 2 months ago

NINI1988 commented 2 months ago
[25 ms] Dev Containers 0.377.0 in VS Code 1.92.0-insider (4a103b0eea7de96d12fc2cbada846ca7ef4f1298).
[25 ms] Start: Run: wsl -l -v
[77 ms] Start: Run: wsl -d Ubuntu -e wslpath -u c:\Working\test\test_devcontainer\test-project
[237 ms] Start: Run: wsl -d Ubuntu -e /bin/sh -c cd '/mnt/c/Working/test/test_devcontainer/test-project' && /bin/sh
[245 ms] Start: Run in host: id -un
[296 ms] nini
[296 ms] 
[297 ms] Start: Run in host:  (command -v getent >/dev/null 2>&1 && getent passwd 'nini' || grep -E '^nini|^[^:]*:[^:]*:nini:' /etc/passwd || true)
[303 ms] Start: Run in host: echo ~
[304 ms] /home/nini
[304 ms] 
[304 ms] Start: Run in host: test -f '/home/nini/.vscode-server-insiders/cli/servers/Insiders-4a103b0eea7de96d12fc2cbada846ca7ef4f1298/server/node'
[305 ms] 
[305 ms] 
[305 ms] Exit code 1
[306 ms] Start: Run in host: test -f '/home/nini/.vscode-insiders/cli/servers/Insiders-4a103b0eea7de96d12fc2cbada846ca7ef4f1298/server/node'
[306 ms] 
[306 ms] 
[306 ms] Exit code 1
[307 ms] Start: Run in host: test -f '/home/nini/.vscode-server-insiders/bin/4a103b0eea7de96d12fc2cbada846ca7ef4f1298/node'
[308 ms] 
[308 ms] 
[308 ms] Exit code 1
[308 ms] Start: Run in host: test -f '/home/nini/.vscode-remote-containers/bin/4a103b0eea7de96d12fc2cbada846ca7ef4f1298/node'
[309 ms] 
[309 ms] 
[309 ms] Start: Run in host: test -f '/home/nini/.vscode-remote-containers/bin/4a103b0eea7de96d12fc2cbada846ca7ef4f1298/node_modules/node-pty/package.json'
[310 ms] 
[310 ms] 
[310 ms] Start: Run in host: test -f '/home/nini/.vscode-remote-containers/dist/vscode-remote-containers-server-0.377.0.js'
[311 ms] 
[311 ms] 
[311 ms] userEnvProbe: loginInteractiveShell (default)
[312 ms] userEnvProbe: not found in cache
[312 ms] userEnvProbe shell: /bin/bash
[512 ms] userEnvProbe PATHs:
Probe:     '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/Program Files/Python312/Scripts/:/mnt/c/Program Files/Python312/:/mnt/c/Program Files/Python37/Scripts/:/mnt/c/Program Files/Python37/:/mnt/c/Program Files (x86)/Common Files/Oracle/Java/javapath:/mnt/c/Windows/system32:/mnt/c/Windows:/mnt/c/Windows/System32/Wbem:/mnt/c/Windows/System32/WindowsPowerShell/v1.0/:/mnt/c/Windows/System32/OpenSSH/:/mnt/c/Program Files/PuTTY/:/mnt/c/Program Files/Git/cmd:/mnt/c/Program Files/SourceGear/Common/DiffMerge/:/mnt/c/Program Files/dotnet/:/mnt/c/Program Files (x86)/Windows Kits/10/Windows Performance Toolkit/:/mnt/c/Program Files/nodejs/:/mnt/c/Users/username/AppData/Local/Programs/Python/Launcher/:/mnt/c/Users/username/AppData/Local/Programs/Python/Python39/Scripts/:/mnt/c/Users/username/AppData/Local/Programs/Python/Python39/:/mnt/c/Users/username/AppData/Local/Programs/Python/Python312/Scripts/:/mnt/c/Users/username/AppData/Local/Programs/Python/Python312/:/mnt/c/Users/username/AppData/Local/Microsoft/WindowsApps:/mnt/c/Users/username/AppData/Local/Programs/Microsoft VS Code/bin:/mnt/c/Users/username/AppData/Roaming/Python/Python312/Scripts:/mnt/c/Program Files (x86)/GnuWin32/bin:/mnt/c/msys64/mingw64/bin:/mnt/c/Users/username/AppData/Local/Programs/Microsoft VS Code:/mnt/c/Users/username/AppData/Roaming/npm:/snap/bin'
Container: None
[539 ms] Initializing configuration support...
[540 ms] Internal initialization of dev container support package...
[5342 ms] Start: Run in Host: docker version --format {{json .}}
[5357 ms] {"Client":{"Platform":{"Name":"Docker Engine - Community"},"Version":"27.0.3","ApiVersion":"1.46","DefaultAPIVersion":"1.46","GitCommit":"7d4bcd8","GoVersion":"go1.21.11","Os":"linux","Arch":"amd64","BuildTime":"Sat Jun 29 00:02:33 2024","Context":"default"},"Server":{"Platform":{"Name":"Docker Engine - Community"},"Components":[{"Name":"Engine","Version":"27.0.3","Details":{"ApiVersion":"1.46","Arch":"amd64","BuildTime":"Sat Jun 29 00:02:33 2024","Experimental":"false","GitCommit":"662f78c","GoVersion":"go1.21.11","KernelVersion":"5.15.153.1-microsoft-standard-WSL2","MinAPIVersion":"1.24","Os":"linux"}},{"Name":"containerd","Version":"1.7.18","Details":{"GitCommit":"ae71819c4f5e67bb4d5ae76a6b735f29cc25774e"}},{"Name":"runc","Version":"1.7.18","Details":{"GitCommit":"v1.1.13-0-g58aa920"}},{"Name":"docker-init","Version":"0.19.0","Details":{"GitCommit":"de40ad0"}}],"Version":"27.0.3","ApiVersion":"1.46","MinAPIVersion":"1.24","GitCommit":"662f78c","GoVersion":"go1.21.11","Os":"linux","Arch":"amd64","KernelVersion":"5.15.153.1-microsoft-standard-WSL2","BuildTime":"2024-06-29T00:02:33.000000000+00:00"}}
[5359 ms] Start: Run in Host: wslpath -w c:/Working/test/test_devcontainer/test-project
[5471 ms] Command failed: ls -a c:/Working/test/test_devcontainer/test-project
[5472 ms] ls: cannot access 'c:/Working/test/test_devcontainer/test-project': No such file or directory
[5472 ms] Exit code 2

Steps to Reproduce:

  1. Open a folder with VsCode which contains a devcontainer on windows
  2. VsCode will open a popup to ask "Reopen in Container" Screenshot 2024-07-17 115425
  3. This fails with the supplied Logs.
  4. But when I run "Reopen in Container" from command palette it works Screenshot 2024-07-17 115449

Additional information

Does this issue occur when you try this locally?: Yes Does this issue occur when you try this locally and all extensions are disabled?: Yes, Except WSL and Dev Container are installed.

chrmarti commented 2 months ago

To verify on Windows:

canton7 commented 2 months ago

Has this been fixed? I don't see any relevant PRs.

I (and the rest of my team) have had the same issue for about 6 months or so (I'm afraid I don't have the exact version which broke it), and it's still a problem today.

rzhao271 commented 2 months ago

Dev containers seems broken on my Windows machine for an unrelated reason. Leaving to someone else to verify.

wslpath error modal upon trying to add a configuration file

chrmarti commented 2 months ago

I'm only now running the build to publish a new pre-release version with the fix. Will notify here when done. Thanks!

chrmarti commented 2 months ago

Dev containers seems broken on my Windows machine for an unrelated reason. Leaving to someone else to verify.

wslpath error modal upon trying to add a configuration file

@rzhao271 That looks like you inadvertently made docker-desktop-data your default WSL distro. You can check with wsl -l -v which one has the asterisk that's the default.

chrmarti commented 2 months ago

This is now available in Dev Containers 0.379.0-pre-release.

canton7 commented 2 months ago

Works for me, thank you!

NINI1988 commented 2 months ago

Thank you very much @chrmarti, it works now.