search

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.69k stars 296 forks source link

[Remote-SSH] consider wget2 #10350

Open GongT opened 1 month ago

GongT commented 1 month ago

a (tiny-) bug report.

I debug another issue these day, and found a tiny problem in installer script.

1: detect wget2 On fedora-40, we use wget2 replaced old wget (in-place, still call it with /usr/bin/wget). wget2 works EXTREAMLY well, especially in a bad network environment. What user need to do is run it with wget https://xxxx -O /some/file, no any flag need/should exists.

It has --no-config flag, but not mention in --help output. So Detected that this version of wget does not support '--no-config'. Will not ignore wget default configuration files., but it's false.

2: remote.SSH.useCurlAndWgetConfigurationFiles when set remote.SSH.useCurlAndWgetConfigurationFiles to true, IGNORE_WGET_CONFIG_FLAG and IGNORE_CURL_CONFIG_FLAG will be " " (a space), cause curl/wget --help useless run.

Feature Request

Please consider implement a extendable timeout.

It should not timeout during Installing and setting up Visual Studio Code Server. Timeout and retry not help, but make things even worse. (at lease it should continue download, not from start again)

It may timeout if server not print "server download progress" longer than X seconds.

joshspicer commented 1 month ago

Thanks for the report. I've found it's difficult to detect all the different flavors of wget/curl that could be out there on remote machines. I'll test with wget2

GongT commented 1 month ago

@joshspicer I have added some more text, please have a look, thanks!