search

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.68k stars 295 forks source link

Too many safe declarations in .gitconfig #10484

Closed arterrey closed 4 days ago

arterrey commented 1 month ago

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

I don't know how to reproduce, but inside my remote remote container I have a .gitconfig that looks like

/root/.gitconfig:

[user]
        name = ***
        email = ***
[filter "lfs"]
        clean = git-lfs clean -- %f
        smudge = git-lfs smudge -- %f
        process = git-lfs filter-process
        required = true
[credential]
        helper = ***

[pull]
        rebase = true
[safe]
        directory = /main
        directory = /main
        directory = /main
        directory = /main
        directory = /main
        directory = /main
        directory = /main
        directory = /main
        directory = /main
...
[snip about 16,000 lines]
...
        directory = /main
        directory = /main
        directory = /main
        directory = /main

The expected output is to just have one directory = /main lines instead of 16k.

~ # grep 'directory = /main' .gitconfig | wc
  16103   48309  305957
lszomoru commented 1 month ago

@arterrey, what happens if you clear these out manually? Could you please try that and see if you can track down this operation adds the entry back?

arterrey commented 1 month ago

I’ll observe over the next day or so.

On 18 Oct 2024 at 16:57:24, Ladislau Szomoru @.***> wrote:

@arterrey https://github.com/arterrey, what happens if you clear these out manually? Could you please try that and see if you can track down this operation adds the entry back?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-remote-release/issues/10484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEWR4E2DBXTPCV3GY73PXLZ4DLQJAVCNFSM6AAAAABQEVEWNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSGAZDGOJYGI . You are receiving this because you were mentioned.Message ID: @.***>

arterrey commented 5 days ago

I cleared out the file and entities are combing back.

chrmarti commented 4 days ago

@arterrey I guess you have the .gitconfig mounted from the host machine?