search

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.66k stars 286 forks source link

Ports protocol api for web not behaving as expected #5424

Closed ghost closed 3 years ago

ghost commented 3 years ago

The ports protocol context menu doesn't reflect the protocol assigned to the tunnel object. This happens in codespaces web on the latest versions of insiders and stable.

Repro steps for codespaces:

  1. Update codespaces workbench to set the tunnel protocol as the context menu selection. Do this by adding protocol: tunnelOptions.protocol to the tunnel object here.
  2. Try to change the protocol through the context menu. Confirm the protocol is correctly being assigned to the tunnel object by setting a breakpoint.

Current Behavior:

The protocol ui doesn't reflect the protocol assigned to the tunnel object.

Expected Behavior:

The checkmark for selected protocol should reflect the protocol assigned to the tunnel object.

Making a similar change in the codespaces extension works as expected on the desktop versions of insiders and stable.

alexr00 commented 3 years ago

@wachaudh is there a way I can repro this without trying to make changes to the Codespaces extension since I'm not setup to build that from source?

ghost commented 3 years ago

Discussed repro steps offline.

alexr00 commented 3 years ago

I tried to repro, but everything is still working well and I see the expected behavior.

klvnraju commented 3 years ago

Thanks for looking into this Alex. I just validated that it works as expected.