2 errors (dialog, toast) when connecting to non existing host

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.

https://aka.ms/vscode-remote

Other

3.67k stars 289 forks source link

2 errors (dialog, toast) when connecting to non existing host #5778

Open bpasero opened 3 years ago

bpasero commented 3 years ago

Testing #5770

bpasero commented 3 years ago

Similar for a timeout:

tanhakabir commented 3 years ago

This was the behaviour from before. @roblourens do you see any problems in the flow if I remove the toast notification?

roblourens commented 1 year ago

The modal is from Remote-SSH, we want that. The notification is from vscode, that should not be showing up. We should check

That we set handled to true for errors that cause us to show a dialog
And that handled is checked correctly by vscode https://github.com/microsoft/vscode/blob/f3cf0861ab923640073a68e3043897a91e8710da/src/vs/platform/remote/common/remoteAuthorityResolver.ts#L96