search

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.61k stars 276 forks source link

Blocked port ignored #7607

Open sbatten opened 1 year ago

sbatten commented 1 year ago

Testing #7594

Following the steps in the test plan, it does not seem to care if I block the only port or not. I get no error messages and it connects fine.

eleanorjboyd commented 1 year ago

Hi! Could you send your remote-ssh logs so I can take a closer look at why you might have been able to connect to a port you blocked?

sbatten commented 1 year ago

I tried reproducing and it worked as expected. Then I expanded the port range, connected, and then reset it back to 1 port (which was blocked). Even after running "Kill current vs code server", connecting reuses the unblocked port even though it is no longer in range. Perhaps this is a timeout problem?

eleanorjboyd commented 1 year ago

I will try and repro this and let you know if I can't and need more details. Thanks!

github-actions[bot] commented 1 year ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!