search

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.67k stars 292 forks source link

Dev Container through SSH sometimes only shows "[Dev Container]" instead of "[Dev Container Image @ ssh://remote]" on Get Started page #8578

Open amurzeau opened 1 year ago

amurzeau commented 1 year ago

Dev Container extension version : v0.294.0 Remote - SSH extension version : v0.103.2023060615

Steps to Reproduce:

  1. Have 2 differents SSH hosts 2.On each SSH hosts, do this:

    1. Create a testdevcontainer folder
    2. In this folder, create a .devcontainer/devcontainer.json file containing this text: 
      {
"name": "Alpine",
"image": "mcr.microsoft.com/devcontainers/base:alpine-3.16",
"remoteUser": "root"
}

  2. Open the first SSH host using Remote Explorer

  3. Open the testdevcontainer folder using Open Folder button on the Get Started page

  4. When asked to, click on Reopen in Container: image

  5. Close the Container

  6. Do the same thing with the second SSH host

  7. Close the Container

  8. The Get Started page shows duplicated testdevcontainer [Dev Container]: image

Instead, I'm expecting this instead of testdevcontainer [Dev Container]:

Does this issue occur when you try this locally?: No Does this issue occur when you try this locally and all extensions are disabled?: No

bamurtaugh commented 1 year ago

Thanks for opening!

When actually connected to each dev container, do you see Dev Container Alpine @ ssh://debian64 and Dev Container Alpine @ ssh://debian64_2 in the remote indicator?

amurzeau commented 1 year ago

Yes, I see the complete label in the remote indicator like Dev Container: Alpine @ ssh://debian64.

I've retried with latest insiders:

In bottom left remote indicator of Dev Container Alpine @ ssh://local folder: image

In bottom left remote indicator of Dev Container Alpine @ ssh://local_2 folder: image

The same name shows in the Explorer panel and the title bar: image image

In Get Started: image

VSCode version: Version: 1.80.0-insider Commit: 636dbcff557af8aa088ae118b1a094dce6632ce7 Date: 2023-06-21T08:21:04.745Z Electron: 22.3.13 ElectronBuildId: 21803499 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 6.3.0-1-amd64

bamurtaugh commented 1 year ago

Thanks so much for the great details!

The abbreviation in the getting started or recent area seems potentially intentional to me - tagging @chrmarti @bhavyaus for further thoughts

github-actions[bot] commented 1 year ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

amurzeau commented 1 year ago

No more information was asked, so I guess this was wrongly closed automatically. Can this issue be reopened ?

bhavyaus commented 9 months ago

This issue requires change to the reported label of Dev container workspaces. The getting started service simply reports the returned label here:

https://github.com/microsoft/vscode/blob/fe0632cbb2d6d3517676748a9601d3cb3dc36b01/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts#L964-L965