search

microsoft / vscode-remote-release

Visual Studio Code Remote Development: Open any folder in WSL, in a Docker container, or on a remote machine using SSH and take advantage of VS Code's full feature set.
https://aka.ms/vscode-remote
Other
3.64k stars 285 forks source link

Opening EOL errors that show when opening the folder results in 2x the errors #9024

Open alexr00 opened 1 year ago

alexr00 commented 1 year ago

Testing #9020

  1. Have .devcontainer\example\devcontainer.json with 
    {
"image":"mcr.microsoft.com/devcontainers/typescript-node:0-20",
"features": {
    "fish": "latest",
    "homebrew": "latest",
    "git": "latest"
}
}
  2. Open the folder that contains the above in VS Code
  3. ✅see that there are 2 errors about EOL features in the Problems view even though there are no files open
  4. Click on one of the problems
  5. The problems are now duplicated image
chrmarti commented 1 year ago

The deprecation warnings from the JSON schema only show while the file is open. The goal here was to always show a warning and that is only possible by adding diagnostics from the extension. We could remove the deprecations from the schema to avoid the duplication, but since the schema is part of the dev container spec, it can be used by other tools and these would no longer have an indication that these features are going to be removed. We have decided to keep the duplication for now and maybe revisit later. Keeping this issue for tracking. Thanks!