search

microsoft / vscode-remote-try-java

Java sample project for trying out Dev Containers
https://aka.ms/vscode-remote/containers/getting-started
MIT License
301 stars 433 forks source link

Add Continuous integration #34

Closed jdubois closed 2 years ago

jdubois commented 2 years ago

Create a Github Action to run continuous integration on Pull Requests

bamurtaugh commented 2 years ago

@chrmarti @joshspicer Do you think including CI makes sense for this repo?

joshspicer commented 2 years ago

I am curious what the use-case is for this change @jdubois?

We run sets of tests against the contents of this repo in the vscode-dev-containers repo. This repo just exists as an easy-to-clone template/example.

jdubois commented 2 years ago

This is both for us (so PRs have a small validation), and for people cloning it (so they have a working CI pipeline by default)

chrmarti commented 2 years ago

The action combines a few standard actions. Anyone cloning the repository might want to customize the sequence and parameters of these actions. It might make more sense to inline the standard actions it: https://github.com/microsoft/nubesgen-actions/blob/main/gitops-build-java-maven/action.yml.

jdubois commented 2 years ago

Oh yes the composite Action was to make it shorter, but I can copy/paste so we use the full steps. Let me update the PR.

jdubois commented 2 years ago

I have removed the composite action @chrmarti @joshspicer