search

microsoft / vscode-remote-try-java

Java sample project for trying out Dev Containers
https://aka.ms/vscode-remote/containers/getting-started
MIT License
301 stars 433 forks source link

added Docker Container #60

Closed mdxabu closed 11 months ago

mdxabu commented 1 year ago

added Dockerfile and runned the App.java in Docker container 🐋

mdxabu commented 1 year ago

@microsoft-github-policy-service agree

bamurtaugh commented 1 year ago

Thank you for taking the time to put together this PR!

The dev container in this repo is based on the Java template in our dev containers org: https://github.com/devcontainers/templates. It's based on our prebuilt Java image in the same org. There's additional info here: https://containers.dev/guide/dockerfile.

Switching to an image-based config rather than Dockerfile-based is a somewhat recent path we've chosen for our dev container references / resources, and we really value the community's feedback. We have an open issue to discuss the presence of Dockerfiles in our templates - if that was part of the motivation for this PR, it'd be great to get your thoughts in our issue: https://github.com/devcontainers/templates/issues/135.

With the above context in mind, I don't think we'll proceed with this PR at this time. If you have any questions or there were other motivations I might not have mentioned, please just let us know. Thanks so much!

mdxabu commented 1 year ago

Thanks for the clarification, @bamurtaugh