search

microsoft / vscode-remote-try-python

Python sample project for trying out Dev Containers
https://aka.ms/vscode-remote/containers/getting-started
MIT License
780 stars 1.63k forks source link

README changes and switch to dynamic port forwarding #16

Closed bamurtaugh closed 3 years ago

bamurtaugh commented 3 years ago

Updated readme to include Remote-Containers and Codespaces, following the practices from https://github.com/microsoft/vscode-remote-try-node/pull/15.

Also updated to use dynamic port forwarding in devcontainer.json.

We previously chatted about converting the remote-try-* repos to template repositories. I figured the PRs I'm opening with updates could also be a good spot to chat about/remind us of this change as well.

bamurtaugh commented 3 years ago

@2percentsilk @Chuxel I made some changes to the sections describing port forwarding (since users can't just go to localhost:port from a browser-based Codespace). If you have any feedback, I'd love to hear it!

2percentsilk commented 3 years ago

@bamurtaugh these changes look great! I really liked the way you made the ports instructions accessible to both products 😄 Let's start with this and we can add info about the toast/a screenshot if we hear any confusion but I think we should go ahead and merge!

bamurtaugh commented 3 years ago

Thanks so much for the feedback @2percentsilk! Going to merge, and we can iterate from there if we see room for improvement like you mention :)