Open gayanper opened 1 year ago
@Eskibear WDYT ?
Instead of introducing a setting to affect the button’s behavior, I would prefer to introduce new tree items for launch configs, as children of the app item. You can click run/debug buttons on the launch config item, in which you can even specify more than profiles, like customized vmargs etc.
-Yan
发件人: Gayan Perera @.> 发送时间: Friday, June 2, 2023 9:50:20 PM 收件人: microsoft/vscode-spring-boot-dashboard @.> 抄送: Yan Zhang @.>; Mention @.> 主题: Re: [microsoft/vscode-spring-boot-dashboard] Add support to select which run debug action flavours to use with app list icons (Issue #322)
@Eskibearhttps://github.com/Eskibear WDYT ?
― Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode-spring-boot-dashboard/issues/322#issuecomment-1573772158, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAR6FBE3QTL6P7AFMBU3KMDXJHVRZANCNFSM6AAAAAAYYLCYBQ. You are receiving this because you were mentioned.Message ID: @.***>
Suggestion: Since launch config is already present, to add vmargs, would it be good if as part of profile selection from app dashboard, we also give prompt option to users to create/update the selected profile(s) as a launch config as well?
@karthik20 it would be great to be able to 'export' the launch configs
Today in the Apps list run and debug icons are used only for running and debugging the application without the profile.
When using profiles such as dev and prod, as a developer I endue always right clicking on the app and selecting run with profile and selecting the profile in the picker. This takes lots of clicks.
As a solution to improve this:
We could introduce a setting which could be a project level setting or workspace level to configure the default profile to use. If the setting is empty we run without a profile, if the given profile is not present in the resolved profiles, then we ask the user to pick.
A setting to switch between which flavour of run/debug actions to use for the icons.
I think the first option might be more simpler and allow cover different use cases. But the second option might be simple to implement.