search

microsoft / vscode-sublime-keybindings

Sublime Text Keymap extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-vscode.sublime-keybindings
MIT License
252 stars 121 forks source link

Support Sublime Text 4 #147

Open cdignam-segment opened 2 years ago

cdignam-segment commented 2 years ago

The configuration paths have changed with Sublime Text 4 so importing settings no longer works.

These paths need to be updated to include support for Sublime Text 4: https://github.com/microsoft/vscode-sublime-keybindings/blob/0b52e3f6f3ec2dcdbdeb8b3c2c7208d8e6fc3a38/src/sublimeFolderFinder.ts#L9

alanfluff commented 2 years ago

Is it no longer possible to import bindings - even by navigating to an alternate location (total newbie to VSC so apologies for asking obvious Qs)?

boxsnake commented 2 years ago

I made this PR to be merged.

https://github.com/microsoft/vscode-sublime-keybindings/pull/149

daniele-niero commented 1 year ago

I made this PR to be merged.

149

Was it merged at all? it seems that the latest version, 4.0.10, still have this issue.

benjaminloerincz commented 1 year ago

It looks to me like the approval process of that PR is somehow broken... There should actually be enough reviewers now 🤷‍♂️

boxsnake commented 1 year ago

It looks to me like the approval process of that PR is somehow broken... There should actually be enough reviewers now 🤷‍♂️

The merge is stuck due to a conflict between branches, and I just did a reverse-merge from main and need further review.