search

microsoft / vscode-tensorboard

Launch and view Tensorboards in VS Code
MIT License
4 stars 3 forks source link

logdir setting has no effect #18

Closed AwePhD closed 7 months ago

AwePhD commented 9 months ago

The setting of the log dir is not taken into account in the extension. Namely, setting the tensorboard log dir does not disable the prompt.

In the related commit, in package.json, we set this setting to be tensorBoard. But in the actual src/configuration.ts, we search a tensorboard. I guess if we uppercase the B on this line, it would fix the problem? (I am not a JS dev, so I cannot be sure at all)

Current workaround, lowercase the B in the JSON config manually. From:

"tensorBoard.logDirectory": "/path/to/log/dir"

To:

"tensorboard.logDirectory": "/path/to/log/dir"
pedroaugustosmribeiro commented 7 months ago

Neither settings work for me VSCode: 1.87.1 (Stable) Commit: 1e790d77f81672c49be070e04474901747115651

YoniChechik commented 6 months ago

@DonJayamanne thanks for this extansion! as of today this fix still doesn't work (on pre-release as well)

this workaround worked for me:

Current workaround, lowercase the B in the JSON config manually. From:

"tensorBoard.logDirectory": "/path/to/log/dir"

To:

"tensorboard.logDirectory": "/path/to/log/dir"
laclouis5 commented 3 months ago

The issue does not seem to be fixed in the last version (v2023.10.1002992421). Do any maintainer have an idea on when this fix will be delivered? Thanks for your work!