microsoft / vscode-test-cli

Command-line runner for VS Code tests
MIT License
19 stars 7 forks source link

Expose c8 excludeAfterRemap argument to coverage config #37

Open mattnotmitt opened 4 months ago

mattnotmitt commented 4 months ago

We have a project which runs tests using the CLI against a webpacked extension and the node_modules aren't correctly excluded from coverage stats even if it's done explicitly. Manually bodging vscode-test-cli to add excludeAfterRemap: true to the Report in coverage.mts allows it to be successfully excluded. Could we get this exposed as an option or set to true by default?

connor4312 commented 4 months ago

Thanks, we should have exclude logic that takes into account sourcemaps. However, I don't want to expose c8 internals directly since that's a bit of an implementation detail (and I might write a v8-to-vscode helper at some point that bypasses istanbul.)