search

microsoft / vscode-test-web

Node module to help testing VS Code web extensions.
MIT License
59 stars 22 forks source link

Make Playwright an optional dependency #37

Open christian-bromann opened 2 years ago

christian-bromann commented 2 years ago

Howdy 👋

I am maintaining WebdriverIO and build a VS Code test plugin for it called wdio-vscode-service. It offers pretty much what @vscode/test-web and @vscode/test-electron do combined with a versatile test framework like WebdriverIO.

It would my life tremendously easier if this package could get rid of the Playwright dependency, which is only used to start up Chromium. There are other packages doing the same job using the actual Chrome browser installed on the system. It would also reduce installation time.

I am happy to make this change. It would allow me to use all the logic to spin up a VS Code server for testing web extensions.

Cheers!

christian-bromann commented 2 years ago

Any comments?

yiliang114 commented 1 year ago

I think it is good.

zm-cttae-archive commented 1 year ago

I have also hit this issue when I tried to bundle it up with Webpack.

Because this dep breaks bundling, that makes it much harder to use targeting web extensions...

For Webpack, it's possible to hack around it by only packing the test runner.

Examples ready to copy: