microsoft / vscode-test-web

Node module to help testing VS Code web extensions.
MIT License
56 stars 21 forks source link

Unable to open files with special characters in the file name #97

Closed slavek-kucera closed 11 months ago

slavek-kucera commented 1 year ago

I am unable to open files that have special characters in their file name (like !#$%&'()+,-.0123456789;=@ABCDEFGHIJKLMNOPQRSTUVWXYZ[]^_`abcdefghijklmnopqrstuvwxyz{}~ or test_utf_8_🧿) that I use during testing. I think that the problem is that URIs are not properly encoded and then decoded in places like https://github.com/microsoft/vscode-test-web/blob/3f0f858ab15cb65ef3c19564b0f5a6910ea9414e/fs-provider/src/fsExtensionMain.ts#L112 and https://github.com/microsoft/vscode-test-web/blob/3f0f858ab15cb65ef3c19564b0f5a6910ea9414e/src/server/mounts.ts#L35

image

aeschli commented 11 months ago

To verify:

slavek-kucera commented 11 months ago

👍 The fix solves the problem. Thank you.