microsoft / vscode-textmate

A library that helps tokenize text using Text Mate grammars.
MIT License
562 stars 108 forks source link

Tagging releases #202

Closed rehmsen closed 1 year ago

rehmsen commented 1 year ago

It seems releases were not tagged since v7.0.1.

@hediet suggested:

Can you create a issue that asks for tags on releases? It would be awesome if you could come up with a PR.

This is how we do it in the monaco editor: https://github.com/microsoft/monaco-editor/blob/main/.azure-pipelines/publish-stable.yml

rehmsen commented 1 year ago

I am happy to contribute, but I first need to understand the current state, and I am a bit confused:

Maybe I am missing something git here, but it looks like it is 88baacf which should be tagged 9.0.0, not 7cf5852.

hediet commented 1 year ago

I believe https://github.com/microsoft/vscode-textmate/commit/d80e58a5ad6b4cc822483e73ad273df01e8ad2b1 is 9.0.0.

rehmsen commented 1 year ago

d80e58a does not have the version bump in the package.json yet though: https://github.com/microsoft/vscode-textmate/blob/d80e58a5ad6b4cc822483e73ad273df01e8ad2b1/package.json#L3

hediet commented 1 year ago

Yes, this is because I created both PRs (the feature and bumping the version) at the same time, but the version bump got reviewed earlier and thus merged earlier.