search

microsoft / vscode-textmate

A library that helps tokenize text using Text Mate grammars.
MIT License
562 stars 108 forks source link

TextMate grammar does not parse correctly under 1.86 #226

Closed tinygiant98 closed 5 months ago

tinygiant98 commented 5 months ago

Type: Bug (Possible regression)

Steps to reproduce: Use the extension under 1.86

We have a language server implementation (as an extension) for a custom language that relies on a textMate grammar. Under 1.85 and all previous versions of vsCode, this textmate grammar parses correctly and the language server reliably provided the product it is designed to supply.

When vscode updated to 1.86, the textmate grammar no longer reliably parses and always errors on a line including </dict>, though the actual grammar component it errors out on varies considerably. This, and the fact that it worked reliably until 1.86, leads me to believe there was a base code change that caused the issue, not the grammar itself, since the grammar hasn't changed in years. Multiple members of our development team have noted the same behavior on 1.86. Reverting to 1.85 fixes the issue for all team members, and on various OS.

VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z) OS version: Windows_NT x64 10.0.19045 Modes:

VSCodeTriageBot commented 5 months ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

RedCMD commented 5 months ago

can you link the extension? thanks

tinygiant98 commented 5 months ago

can you link the extension? thanks

https://github.com/PhilippeChab/nwscript-ee-language-server

RedCMD commented 5 months ago

also a code snippet and screenshot too please

tinygiant98 commented 5 months ago

also a code snippet and screenshot too please

Here's a screenshot of the error condition (I assumed that's what you were looking for). image

Also, here's a random code file in the language that this ls was built for. The extension is .txt, but it needs to be changed to .nss to work with the ls (sorry, github attachment limitation). util_i_matching.txt

aeschli commented 5 months ago

Do you use vscode-textmate to parse the grammar?

tinygiant98 commented 5 months ago

Do you use vscode-textmate to parse the grammar?

Thanks for your attention. It appears that the ls does use vscode-textmate for parsing.

PhilippeChab commented 5 months ago

The issue isn't related to this package, but vscode extension initialization process.

You can close this issue in favor of that one.