[Auth Provider] Finish main extension VS Code auth provider work

microsoft / vscode-tools-for-ai

Azure Machine Learning for Visual Studio Code, previously called Visual Studio Code Tools for AI, is an extension to easily build, train, and deploy machine learning models to the cloud or the edge with Azure Machine Learning service.

Other

324 stars 94 forks source link

[Auth Provider] Finish main extension VS Code auth provider work #2240

Closed shsuman closed 8 months ago

shsuman commented 10 months ago

Continuing from https://github.com/microsoft/vscode-tools-for-ai/issues/2081. Let's get this ready to ship with migrating Subscription filters/Azure Cloud config if possible and implementing any remaining missing functions that the Azure Account extension provided

shsuman commented 10 months ago

[x] Some functions need to be implemented by us like Subscription Filter, Create Azure Account and Select Tenant Id which were previously carried out by Azure Account extension
[x] Backward compatibility is important in things like Azure Cloud config, Subscription Filter, tenant Id etc,..
[x] The VSCodeAzureSubscriptionProvider.isSignedIn() function seems to be really slow, so we might want to cache it
[x] Clear Tenant Id when logging out, maybe a warning like the Azure Account does
[x] Commands for Sign In
[x] Auth flow in Remote extension

shsuman commented 10 months ago

Alex is working on Select Tenant Id command
Azure Resources extension will have commands to set the Microsoft:sovereign-cloud setting and and Microsoft:custom-cloud-env
Tenants may require MFA, need a command to sign in to specific tenant
Only Sign in command but no Sign out command

shsuman commented 10 months ago

Az Account is not gonna be deprecated at least in Ge. But ADAL support can be dropped anytime

shsuman commented 8 months ago

Completed through: