search

microsoft / vscode-tye

A Visual Studio Code extension for Tye development
Other
25 stars 9 forks source link

Make application matching case-insensitive. #173

Closed philliphoff closed 2 years ago

philliphoff commented 2 years ago

Resolves an issue in cases where the user edits the applicationName of the tye launch configuration such that the case no longer matches that in tye.yaml, which prevents the extension from identifying and attaching to application services. The change is to make such matching case-insensitive.

Also removes scaffolding and references to the applicationName property of the tye-run task, as it is no longer used by the extension. (Now only the tye launch configuration will have that property.)

Resolves #167.

philliphoff commented 2 years ago

Yes, it does assume that application names are fundamentally case-insensitive. For the purposes of distinguishing between simultaneously-running applications--which is the only use I know of for the application name--I think that's a reasonable assumption.