microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 35 forks source link

Tslint stops working in VSCode, not showing unhandled exceptions #103

Closed jessesmall closed 1 year ago

jessesmall commented 5 years ago

I was requested due to my review to create a new issue describing my problem and solution. We were using tslint without any issues and then one day it stopped working. I was able to install the older deprecated version of tslint in visual studio code and that was able to actually give me some errors. The error was an un-handled exception due to having a list of mismatched projects in our angular.json and nx.json. By removing the un-necessary projects the old extension began to work correctly again, I then uninstalled the old version and re-installed the newer extension and all was working again. I noticed on the reviews a lot of people are reporting that the extension just stops working, I believe this is due to some un-handled exception being thrown like in my case but the new extension is not showing these errors for us like the old one was so there is no way of knowing how to fix it.

To reproduce this you just need to have an angular project that is using narwhal (nx), then under the nx.json add an extra project under the listed projects or remove a project from the angular.json this should throw an error with the old extension but will simply break the new extension.

The issue is not the extension breaking, but rather the extension not showing errors when it breaks like the old one was. We have fixed our own project and the extension is working great again, this is more for the information of other developers who may come across this issue, it would be great if we could see these errors instead of having to re-install the old deprecated one.

erhise commented 5 years ago

To reproduce this you just need to have an angular project that is using narwhal (nx), then under the nx.json add an extra project under the listed projects or remove a project from the angular.json this should throw an error with the old extension but will simply break the new extension. Could you specify what you mean by this?

I'm using nrwl/nx. I just realized that the tslint extension was not working as it should. Doing

jessesmall commented 5 years ago

I think in your case you may have had a different error than me but sounds like the problem is the same, the errors are not being shown. Maybe the deprecated version had some sort of clean up that fixed whatever wasn't working correctly.

ILlearnPrograming commented 3 years ago

Only version 1.2.3 works for me. Newer versions don't work in VSCode.

mbest commented 3 years ago

It stops working for me as well, seemingly randomly. I have 1.3.3. I tried disable, restart, enable. Then the tslint errors show up, but the autofix feature still doesn't work. I had to exit VS Code and run it again, and then it works properly again.

mjbvz commented 1 year ago

Closing as TSLint has been deprecated in favor of ESLint and this extension is no longer being maintained

Please look into migrating to use ESLint and the ESLint VS Code extension