search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 35 forks source link

Incorrect problem description. #111

Closed scopchanov closed 4 years ago

scopchanov commented 4 years ago

In my opinion the should be part of

The selector should be prefixed by "app" (https://angular.io/guide/styleguide#style-02-07) (component-selector)

is not correct. According to the provided link:

Do use a prefix that identifies the feature area or the app itself.

The given example indeed shows selector: 'hero' as an inapropriate name, but selector: 'toh-hero' is totally acceptable, although it is not prefixed by app in this case.

mjbvz commented 4 years ago

I believe this is an issue with tslint itself or some custom rule, not with this plugin. Please file an issue upstream against them