search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 34 forks source link

Explore supporting "fix on save" #2

Closed mjbvz closed 5 years ago

mjbvz commented 5 years ago

Fix on save is supported by the existing tslint extension. Investigate supporting this with the new plugin based extension as well

Note that this cannot be implemented at the plugin level since the typescript language service has no concept of file saves

dawnmist commented 5 years ago

I've been testing the typescript-tslint-plugin & vscode-typescript-tslint-plugin for the last 3 days, and have reached the point where I am now reverting to the previous tslint plugin.

There are 2 primary reasons for the reversion:

  1. The lack of support for "fix on save"/no "apply all tslint fixes now" shortcut action.
  2. The information about imports popup (window with mouse cursor below) is randomly slow (varies randomly between 2 seconds and more than 30 seconds), and without that information imports do not get added on Ctrl-space and imports such as redux selectors do not tell you which "version" of the selector is which in the list. image

The amount of time involved in working through both those issues has been frustrating, and represents a significantly large amount of the day wasted in comparison to using the old tslint plugin.

I am looking forward to a time when this plugin has matured a bit more so that I can retest/migrate across, but without the fix on save feature or an "apply all tslint fixes" shortcut it breaks the flow of programming too much. Every auto-import (once the window finally appears) results in needing to activate fixes at the top of the file (not where you were working in the file) in order to alphabetize them instead of simply hitting Ctrl-S to save the file and having them fixed automatically. Clicking the lightbulb gives access to "apply all fixes", but it's appearance on the screen suffers from the same random-length delay that the information window popup does before it becomes available to be clicked.

muyu66 commented 5 years ago

The idea of the new project is very good, but now is not the time to move. Waiting for you to be more perfect