search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 34 forks source link

Every lint is considered a "warning" #34

Closed terrybrash closed 5 years ago

terrybrash commented 5 years ago

tslint version: 5.12.0 typescript version: 3.1.6 typescript-tslint-plugin version: 0.2.1 vscode-typescript-tslint-plugin version: 0.2.1

Expected: Errors should be kept intact from tslint, showing red underlines.

tslint.alwaysShowRuleFailuresAsWarnings is disabled.

Actual: Every lint is considered a "warning" in vscode, showing green underlines. Even explicitly specifying a lint as an error in tslint.json doesn't work:

"typedef": {"options": ["call-signature"], "severity": "error"},

Running tslint --project . correctly lists lints with "severity": "error" as an error.

mjbvz commented 5 years ago

In your settings.json, try explicitly adding:

    "tslint.alwaysShowRuleFailuresAsWarnings": false

I think the settings UI shows this option as unchecked (indicating false) when it actually is undefined (meaning to the default value of true)

terrybrash commented 5 years ago

Yep, it works as expected after explicitly setting it.

mjbvz commented 5 years ago

Thanks. This should be fixed by c35672b then

mareksuscak commented 4 years ago

Has this patch ever been released? Using the latest extension and this still appears to be an issue.