search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 34 forks source link

clarify when tsconfig plugins configuration is necessary #50

Closed jrr closed 5 years ago

jrr commented 5 years ago

From the readme:

If you are using VS Code 1.30 or older and are using a workspace version of typescript, you must currently configure the TS Server plugin manually by following these instructions

I'm on VS Code 1.30.2 and a workspace version typescript, and it seems that it's not necessary to add any extra configuration to tsconfig.json. (rules in my tslint.json cause squiggles in VS Code)

Is the readme wrong? Perhaps the extra configuration became unnecessary at some 1.30.x patch level?

mjbvz commented 5 years ago

What are you trying to configure?

jrr commented 5 years ago

Sorry, I worded that poorly.

Today I enabled this plugin for the first time (switching from eg2.tslint).

The readme made it sound like I'd need to put some extra configuration in my tsconfig.json, because I'm using Code 1.30 and a workspace version of typescript.

It seems that this isn't actually the case! I was able to leave my tsconfig.json unchanged, with no plugins section at all, and linting in VS Code is working just fine.

mjbvz commented 5 years ago

ok, since everything seems to be working and since this documentation will be irrelevant once VS Code 1.31 stable ships, I'm closing this