search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 34 forks source link

Too many Fix All action floating around now #52

Closed kieferrm closed 5 years ago

kieferrm commented 5 years ago

Issue Type: Bug

Testing https://github.com/Microsoft/vscode/issues/67295.

With the introduction of the Fix All source action we now have the TS Lint Plugin extensions Fix All code action and the source action. We should think about whether we need both going forward.

VS Code version: Code - Insiders 1.31.0-insider (acc7365e41f9cb380e79bf78d7d102184f1ffe0d, 2019-01-29T06:13:57.866Z) OS version: Darwin x64 18.0.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|16.00GB (0.60GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (28) Extension|Author (truncated)|Version ---|---|--- github-markdown-preview|bie|0.0.2 markdown-checkbox|bie|0.1.1 markdown-emoji|bie|0.0.7 markdown-preview-github-styles|bie|0.1.4 markdown-yaml-preamble|bie|0.0.2 solargraph|cas|0.19.2 ssh|chr|0.0.4 vscode-svgviewer|css|1.4.7 gitlens|eam|9.4.1 vsc-material-theme|Equ|2.6.3 vscode-pull-request-github-insiders|Git|1.29.1 crazy|kie|0.0.2 svgpreview|kis|0.2.0 vscode-azurestorage|ms-|0.5.0 python|ms-|2019.1.0 azure-account|ms-|0.8.0 azurecli|ms-|0.4.2 Go|ms-|0.8.0 vscode-typescript-tslint-plugin|ms-|0.4.0 debugger-for-chrome|msj|4.11.1 vscode-docker|Pet|0.5.1 material-icon-theme|PKi|3.6.2 ruby|reb|0.21.0 vscode-xml|red|0.3.0 bash-debug|rog|0.3.3 kustovscode|sea|0.0.1 php-syntax-visualizer|vsc|0.0.1 vscode-open-in-github|ziy|1.3.6 (2 theme extensions excluded)
mjbvz commented 5 years ago

I don't think the tslint plugin extension contributes any fix-all commands. Are you perhaps using the old eg2-tslint extension? Or perhaps seeing the auto fix command?

kieferrm commented 5 years ago

The is the code action:

image

mjbvz commented 5 years ago

Ok, this is by-design for the tslint extension. For discoverability, we include the fix all autofixable failures action in the lightbulb menu so that people know this action even exists. This matches what the eg2-tslint extension was doing as well

Once the source action API is finalized, we can consider removing fix all from the normal lightbulb menu