microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 35 forks source link

very slow #63

Closed zsytssk closed 1 year ago

zsytssk commented 5 years ago

very slow sometime. It even cant work in some project but the origin Tslint extension work normal.

oneillsp96 commented 5 years ago

Same issue here. Never had issue before the switch.

mjbvz commented 5 years ago

Please provide more info about which version of VS Code you are on, your project setup, which other extensions you have installed, and what is slow

oneillsp96 commented 5 years ago

Extensions: Partial Diff, Rainbow Brackets, vscode-typescript-tslint-plugin VSCode Version: 1.3.1.1

webpack rule applied to .ts files:

{ test: /.tsx?$/, use: [{ loader: "ts-loader", options: { transpileOnly: true, experimentalWatchApi: true } }], exclude: /node_modules/, },

usersettings.json:

{ "window.zoomLevel": 1, "php.validate.executablePath": "C:/Program Files/PHP/php.exe", "git.autofetch": true, "explorer.confirmDelete": false, "files.trimTrailingWhitespace": true, // "tslint.autoFixOnSave": true, "editor.formatOnSave": true, "editor.codeActionsOnSave": { "source.fixAll.tslint": true }, "breadcrumbs.enabled": true, "tslint.ignoreDefinitionFiles": true, "editor.fontFamily": "Consolas, 'Courier New', monospace, Operator Mono", }

tsconfig.json:

{ "compilerOptions": { "allowSyntheticDefaultImports": true, "moduleResolution": "node", "outDir": "dist", "sourceMap": true, "noImplicitAny": true, "noImplicitReturns": true, "strict": true, "module": "es2015", "lib": [ "es7", "dom" ], "experimentalDecorators": true, "target": "es5", "jsx": "react", "allowJs": true, "skipLibCheck": true, "types": [ "webpack-env", "node", "jest" ] }, "include": [ "./src/*/", "./stories/*/" ], "exclude": [ "dist", "node_modules" ] }

oneillsp96 commented 5 years ago

What is slow is the auto-fix on save functionality, which was almost instant with the old extension, and now takes 4-5 seconds

oneillsp96 commented 5 years ago

After disabling auto-save, the plugin is still unusably slow, errs out constantly, and causes me to have to restart Code every 10 minutes. Decision now is ESLint with Typescript config, or back to the deprecated TSLint extension

squidfunk commented 5 years ago

Same here. Unusably slow. Large files take ages to update, leading to race conditions with auto-fix on save where a change was made, the file is saved and TSLint having not caught up breaks the code.

jesnil01 commented 5 years ago

Same issue here. It's so slow I can't believe it.

the-ult commented 5 years ago

Same here. Seems to be needing a lot of resources.

Especially slow while running/watching ng serve app

squidfunk commented 5 years ago

Today, the RC for TypeScript 3.5 was released talking about speed improvements in regard to a regression introduced in 3.4:

Unfortunately, as part of a bug fix in TypeScript 3.4 we accidentally introduced a regression that could lead to an explosion in how much work the type-checker did, and in turn, type-checking time.

As VSCode currently uses 3.4 and this extension makes heavy use of the TypeScript language server, it would explain the slowness. If this is true, we should see improvements with the next VSCode TypeScript dependency upgrade.

mjbvz commented 5 years ago

Does this reproduce in the latest VS Code insiders build?

TheKrisSodroski commented 4 years ago

Having the same issue with this. Very slow, that everything turns to a crawl. Sometimes, when I save, it doesn't recognize the changes fast enough and mangles the entire page.

Disabling the plugin resolves it.

Plugin Version: 1.2.3

Version: 1.43.0 (system setup)
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17134
mjbvz commented 1 year ago

Closing as TSLint has been deprecated in favor of ESLint and this extension is no longer being maintained

Please look into migrating to use ESLint and the ESLint VS Code extension