microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 35 forks source link

Autofix does not fix superfluous formatting #88

Closed douglasg14b closed 1 year ago

douglasg14b commented 5 years ago

The "fix all" option doesn't seem to fix many superfluous formatting issues. Such as:

Is this expected behavior? These seem like they would be automatically correctable? Some of these work inconsistently. Such as leading and trailing whitespace work on function declarations, but seemingly on nothing else.

egamma commented 5 years ago

@douglasg14b from the version number of the extension I conclude that this is for the new tslint extension and not the deprecated one you have reported the issue against.

Moving to the other repo.

douglasg14b commented 5 years ago

Yep. that would be correct!

AdrianPal commented 5 years ago

Same for me...

mjbvz commented 5 years ago

I can't repo this using 1.2.0 of this extension and tslint 5.1.6. For example, for the file:

//comment
const str= 'ab'  

Fix all formats it to:

// comment
const str = "ab"  

The only one that is not fixed is the trailing whitespace on the second line because it overlaps with the missing semicolon and change.

Please share some example code where it does not work

egamma commented 1 year ago

This extension has been depreacted