search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 35 forks source link

Comment flags are ignored #91

Closed GoGoris closed 1 year ago

GoGoris commented 5 years ago

Ignoring rules using comment flags does not work.

Steps to reproduce:

  1. Enable the rule triple-equals in tslint.json
  2. Create a typescript file with the following contents: 
    /* tslint:disable:triple-equals */
const doubleEquals = 0 == false;

Documentation: https://palantir.github.io/tslint/usage/rule-flags/

mjbvz commented 5 years ago

I can't repo this in version 1.2.0 of this extension with tslint 5.1.6

Are you sure the error you are seeing is from tslint? Your example produces a TS error as well

mjbvz commented 1 year ago

Closing as TSLint has been deprecated in favor of ESLint and this extension is no longer being maintained

Please look into migrating to use ESLint and the ESLint VS Code extension