search

microsoft / vscode-typescript-tslint-plugin

VS Code extension that provides TSLint support using the typescript-tslint-plugin
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
MIT License
188 stars 35 forks source link

ProblemMatcher - owner #95

Closed probert94 closed 3 years ago

probert94 commented 5 years ago

When I run tslint as a task, using the $tslint5 ProblemMatcher, the problems will be shown twice, as soon as I open an affected file. When I fix the problem, one of them will disappear, but the one from the task will still remain. The same task worked well with the now deprecated TSLint Plugin. My guess is, that since this plugin is running tslint as a tsserver-plugin, the owner of the problems is not tslint anymore. So the owner-property of the ProblemMatchers should probably be changed to the owner of tsserver.

probert94 commented 5 years ago

I was looking for the owner name of the tsserver and found that it is typescript. Therefore I searched for the $tsc problemMatcher and found this configuration. So the owner seems to be typescript and the problemMatcher only applies to closed documents. This seems to be a good solution for the tslint problem matcher too. However, there is one issue with that: If the tsserver is not started yet, all warnings will be cleared as soon as tsserver starts (for example when opening the first *.ts file).
I guess that this is the same for the $tsc problemMatcher and could probably be ignored as it is less annoying then the duplicate errors.

probert94 commented 3 years ago

Closing since TSLint has been deprecated