Keyboard shortcuts from extension not applied

[dardino]

• VS Code Version: 1.55.0 - insider
• OS Version: Window 10

Steps to Reproduce:

1. install vscode insider
2. install ms-vscode.vs-keybindings
3. open keyboard shortcut preferences:
4. see the difference between the shortcut in the menu and the setting for "Save all" command
5. try to save all with menu defined shortcut works
6. try to save all with preferences defined shortcut doesn't works

Does this issue occur when all extensions are disabled?: Not applicable

[vscodebot[bot]]

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• the keyboard shortcut of clearing the terminal doesn't work rightly (#95411)
• command tooltip and keyboard shortcut name should be the same. (#110407)
• Show keyboard shortcuts inside integrated terminal in Screencast Mode (#81537)
• Updating a keyboard shortcut requires a restart for the visual confirmation on macOS (#118134)
• Incorrect keyboard shortcut shown in menu. (#85798)

[dardino]

similar to: https://github.com/microsoft/vscode/issues/85798

[sandy081]

@alexdima @deepak1556 Assigning it to you both because

1. One report is about execution of keybinding not working
2. Menu is showing different keybinding.

Please let me know if there is something I can help with.

[alexdima]

It looks like the are actually two distinct commands:

• saveAll (this is the one displayed in the menu and is bound to ctrl+k s)
• workbench.action.files.saveAll (this is the one that is bound to ctrl+shift+s by the VS keymap extension)

I think that perhaps at one point we migrated the File menu from workbench.action.files.saveAll to saveAll and forgot to update the VS keymap extension.

@bpasero Assigning to you to clear up what the VS keymap should do here @rebornix Assigning to you for adoption in the VS keymap extension

[bpasero]

saveAll sounds like the correct action to me because workbench.action.files.saveAll seems to originate from the open editors view, but I am not sure why we need to have it:

https://github.com/microsoft/vscode/blob/07a458dd6818766aae91d1d7ff68baa83497b503/src/vs/workbench/contrib/files/browser/views/openEditorsView.ts#L754-L774

Adding @isidorn who maybe added it?

[isidorn]

@bpasero looks like historical reasons. We could remove it, but probably some users are using it, so I would prefer to leave the duplicated ids.

[bpasero]

Ok, then I suggest that the keymap extension is updated to use the saveAll command and not the other one that is open editors specific.

[rebornix]

@chrisdias is now the owner of the keymap ;)