search

microsoft / vscode-webview-ui-toolkit

A component library for building webview-based extensions in Visual Studio Code.
MIT License
2.01k stars 142 forks source link

A11y_VscodeWebviewUiToolkit_AllComponents_Combobox_ScreenReader: The NVDA does not announces the names of the menu items like "option label#1" when navigating using down arrow key. #181

Closed Shivamd1 closed 2 years ago

Shivamd1 commented 3 years ago

Actual:

The NVDA does not announces the names of the menu items like "option label#1" when navigating using down arrow key. It only announces "blank" for all the menu items

Similar issue is observed with Jaws

Similar issue is with the "Dropdowns" scenario

Expected:

The NVDA should be announcing the names of the menu items like "option label#1" along with menu item numbering like 1 of 3 when navigating using down arrow key.

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_VscodeWebviewUiToolkit_Aug2021;#Webview UI Toolkit for Visual Studio Code;#Win32;#FTP;#DesktopApp;#WCAG1.3.1;#NVDA;#Jaws;#STP;#AINotInScope;

Environment Details:

Application Name: Vscode Webview Ui Toolkit Windows Version: Win10 Screen Reader: NVDA(2021.1), Jaws(2021.2102.34)

Repro Steps:

  1. Launch VS Code
  2. Open WebView UI Toolkit: All Component extension
  3. Tab to Combo box element and tab to first combo box and expand it
  4. Start NVDA use down arrow to navigate and check the announcement

User Impact:

Screen Reader users will not get the proper information about the menu items in comboboxes

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

daviddossett commented 3 years ago

Identified that this issue is dependent on this issue being fixed in microsoft/fast, which we take as a dependency here.

Shivamd1 commented 3 years ago

Thanks for the update!

yannickowow commented 3 years ago

Hello! First of all thanks for this work! Is this issue related to onSelect event not fired ? Currently, I cannot get the new value of a vscode-dropdown. I am using these components with React/TSX.

daviddossett commented 3 years ago

Thanks for letting us know @yannickowow. We will investigate and report back.

@chrisdholt does this sound familiar at all?

chrisdholt commented 3 years ago

Thanks for letting us know @yannickowow. We will investigate and report back.

@chrisdholt does this sound familiar at all?

I think this is an NVDA bug - I’ll dig in a bit today to confirm.

chrisdholt commented 3 years ago

Sounds like @radium-v has a draft PR out. That also may collide with multiselect support which is in progress. We're going to get this pri'd and will do a run through with our a11y team before merging/shipping. Let's keep the dependency open on https://github.com/microsoft/fast/issues/5243.

daviddossett commented 3 years ago

Fantastic, thank you Chris!

Shivamd1 commented 2 years ago

@hawkticehurst Could you please provide the latest vsix file so that we can verify it, also could you please reopen the bug, it should only be closed by trusted tester

Roopesh-T commented 1 year ago

@hawkticehurst @daviddossett Could you please provide the latest vsix file so that we can verify it, also could you please reopen the bug, it should only be closed by trusted tester

daviddossett commented 1 year ago

@Roopesh-T we actually removed this code from the library so it's no longer applicable for a11y testing.

Roopesh-T commented 1 year ago

As per the above comment, the code is removed from the library, so closing the bug. GitHub:#Closed; image

image